(Re-)Run checkout script if workspace was modified #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a checkoutScript or some checkoutAssert's and the checkout workspace was changed since the last time, we must re-run the step. This fixes a problem on Jenkins builds where the checkoutScript modifies a git repository. This change will be squashed by the Jenkins git plugin every time the job runs. Now if the script was marked deterministic, Bob still has to run it again to re-apply any modifications. Another example are code generators that should probably be run again if the workspace has changed. In fact, if the script was enabled for checkout-only updates (checkoutUpdateIf), then such modifications would already trigger the re-run if the workspace was modified.
Sometimes its hard to know why a checkout step was executed because there are a couple of possible reasons. Let the user know why exactly the checkout as triggered instead of guessing.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #549 +/- ##
==========================================
- Coverage 88.73% 88.73% -0.01%
==========================================
Files 46 46
Lines 14697 14722 +25
==========================================
+ Hits 13041 13063 +22
- Misses 1656 1659 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.